Skip to content

Conversation

@wofferl
Copy link
Collaborator

@wofferl wofferl commented Jan 27, 2026

@Grotax @SMillerDev
Because the actions failed lately, I changed this PR to also pin all unpinned actions.

The actions actions/[email protected] and actions/[email protected] are not allowed in nextcloud/news because all actions must be pinned to a full-length commit SHA.

Checklist

@wofferl wofferl added 3. to review Skip-Changelog No changelog update is required, minor change labels Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wofferl wofferl changed the title workflows: add Skip-Changelog label to npm audit fix workflows: pin all actions to full-length commit SHA Jan 27, 2026
@wofferl wofferl force-pushed the fix_npm_audit_workflow branch from 3778821 to 5b344c0 Compare January 27, 2026 20:49
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just introduce zizmor to check for this and more issues

@wofferl
Copy link
Collaborator Author

wofferl commented Jan 28, 2026

Maybe we should just introduce zizmor to check for this and more issues

https://help.nextcloud.com/t/pinned-actions-enforced-in-nextcloud-github-org/239414

It seems that "end of the week" was earlier for us

@SMillerDev SMillerDev merged commit cef80ff into nextcloud:master Jan 28, 2026
33 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Skip-Changelog No changelog update is required, minor change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants