fix: respect the proxy configuration and use the correct user agent for all http fetcher clients #3533
+50
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses proxy configuration and user agent issues in HTTP clients across the News app by centralizing HTTP client configuration. This is a follow-up to PR #3528 that resolves the root cause of requests getting stuck due to improper HTTP client configuration.
Changes:
- Introduces a new
getHttpClient()method inFetcherConfigto centralize Guzzle client configuration with consistent user agent, timeout, and proxy settings - Updates the existing
getClient()method to use the new centralized configuration - Migrates
hasLastModifiedHeader()anddownloadFavicon()inFeedFetcherto use the centralized client factory - Adds proxy configuration support to the Scraper's cURL implementation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/Config/FetcherConfig.php | Added getHttpClient() method to centralize Guzzle client configuration and refactored getClient() to use it; added CONNECT_TIMEOUT constant |
| lib/Fetcher/FeedFetcher.php | Replaced direct Client instantiations with calls to getHttpClient(); removed redundant User-Agent header from downloadFavicon request options; removed unused import |
| lib/Scraper/Scraper.php | Added proxy configuration support by checking and applying proxy settings from FetcherConfig |
| CHANGELOG.md | Documented the fix for proxy configuration issues in feed logo download and fulltext scraper |
…or all http fetcher clients Signed-off-by: Wolfgang <[email protected]>
wofferl
force-pushed
the
fix_http_client_headers
branch
from
46cdfac to
03b9b3d
Compare
Grotax
approved these changes
Jan 31, 2026
SMillerDev
approved these changes
Jan 31, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow up to #3528 that fixes the real problem that the different http clients uses wrong user agents and don't respect the proxy confguration.
That is why the client requests can stuck (propably blocked by CDN).
Therefore, the configuration is now standardised via getHttpClient in the FetcherConfig.
Different timeout values or optional parameters can be set via $config parameter.
Checklist