Skip to content

fix(View): Handle ICacheEntry returned by FileInfo->getData()#57878

Merged
provokateurin merged 1 commit intomasterfrom
fix/view/put-fileinfo-cacheentry
Jan 28, 2026
Merged

fix(View): Handle ICacheEntry returned by FileInfo->getData()#57878
provokateurin merged 1 commit intomasterfrom
fix/view/put-fileinfo-cacheentry

Conversation

@provokateurin
Copy link
Member

private array|ICacheEntry $data;
can be an array or ICacheEntry, so we need to handle it and turn it into an array. Otherwise
return $cache->put($internalPath, $data);
fails, because it expects an array.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Jan 28, 2026
@provokateurin provokateurin requested a review from a team as a code owner January 28, 2026 14:13
@provokateurin provokateurin requested review from ArtificialOwl, come-nc, icewind1991 and sorbaugh and removed request for a team January 28, 2026 14:13
@provokateurin provokateurin added the 3. to review Waiting for reviews label Jan 28, 2026
@provokateurin
Copy link
Member Author

/backport to stable33

@provokateurin
Copy link
Member Author

/backport to stable32

@provokateurin
Copy link
Member Author

/backport to stable31

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/view/put-fileinfo-cacheentry branch from 7005bd2 to d7fa94b Compare January 28, 2026 14:34
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I both if statement won't be true. Else if wouldn't be what I would do expected.

@provokateurin provokateurin merged commit cf1fc78 into master Jan 28, 2026
204 of 206 checks passed
@provokateurin provokateurin deleted the fix/view/put-fileinfo-cacheentry branch January 28, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants