fix(View): Handle ICacheEntry returned by FileInfo->getData()#57878
Merged
provokateurin merged 1 commit intomasterfrom Jan 28, 2026
Merged
fix(View): Handle ICacheEntry returned by FileInfo->getData()#57878provokateurin merged 1 commit intomasterfrom
provokateurin merged 1 commit intomasterfrom
Conversation
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
CarlSchwan
reviewed
Jan 28, 2026
Signed-off-by: provokateurin <kate@provokateurin.de>
7005bd2 to
d7fa94b
Compare
CarlSchwan
approved these changes
Jan 28, 2026
AndyScherzinger
approved these changes
Jan 28, 2026
Member
AndyScherzinger
left a comment
There was a problem hiding this comment.
I both if statement won't be true. Else if wouldn't be what I would do expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
server/lib/private/Files/FileInfo.php
Line 21 in 7005bd2
server/lib/private/Files/View.php
Line 1679 in 7005bd2