Skip to content

Conversation

@d4straub
Copy link
Contributor

I added that module in nf-core/detaxizer#86. After linting issues the nf-core bot corrected the meta.yml and that required again a diff. This should solve the problem.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@d4straub d4straub marked this pull request as ready for review November 11, 2025 14:20
@jfy133
Copy link
Member

jfy133 commented Nov 11, 2025

Thanks @d4straub 1

@jfy133 jfy133 added this pull request to the merge queue Nov 11, 2025
Merged via the queue into master with commit 9da6f5c Nov 11, 2025
12 checks passed
@jfy133 jfy133 deleted the d4straub-patch-blastn-meta.yml branch November 11, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants