Skip to content

Conversation

@ewels
Copy link
Member

@ewels ewels commented Jan 22, 2026

Summary

  • Remove " pipeline parameters" suffix from the nextflow_schema.json title attribute
  • The title now just contains the pipeline name (e.g., nf-core/rnaseq instead of nf-core/rnaseq pipeline parameters)

Changes

  • Updated template nextflow_schema.json title from {{ name }} pipeline parameters to {{ name }}
  • Updated schema validation in schema.py to expect just the pipeline name
  • Updated lint documentation examples in schema_lint.py
  • Updated test assertions in test_schema.py
  • Updated test schema in utils_nfschema_plugin

@github-actions

This comment was marked as resolved.

@ewels ewels changed the base branch from main to dev January 22, 2026 22:46
Remove ' pipeline parameters' suffix from the schema title attribute.
The title now just contains the pipeline name for cleaner display.
@ewels ewels force-pushed the json-schema-no-pipeline-parameters branch from 852303d to ae49912 Compare January 22, 2026 22:46
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (c02f3d9) to head (ae49912).

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu
Copy link
Contributor

mashehu commented Jan 23, 2026

Why? These are the pipeline parameters after all.

@ewels
Copy link
Member Author

ewels commented Jan 23, 2026

I think it should be the pipeline title, not the title of the file.

(a) I think it's a bit self-evident and uninformative, and (b) we will likely extend this schema file in the near(ish) future to include other pipeline information that isn't just parameters.

@mashehu mashehu changed the base branch from dev to template-update January 23, 2026 09:25
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched the target branch to try to keep template updates out of the dev branch for a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants