src: cache context lookup in vectored io loops #61387
Open
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61387 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 704 704
Lines 208849 208849
Branches 40324 40333 +9
=======================================
+ Hits 184903 184909 +6
+ Misses 15925 15919 -6
Partials 8021 8021
🚀 New features to boost your workflow:
|
addaleax
approved these changes
Jan 15, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
You can also move Realm::context() into node_realm-inl.h so that the compiler can already make this optimization itself.
Member
Author
thanks, I used |
addaleax
approved these changes
Jan 16, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Be sure to update the commit message/PR title here as well
mertcanaltin
force-pushed
the
mert/fs-cache-context-in-vectored-io
branch
2 times, most recently
from
1ed8448 to
3d040d1
Compare
mertcanaltin
force-pushed
the
mert/fs-cache-context-in-vectored-io
branch
from
b673036 to
cc8df6b
Compare
mertcanaltin
changed the title
addaleax
reviewed
Jan 19, 2026
addaleax
approved these changes
Jan 20, 2026
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Jan 20, 2026
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to prevent the call from being repeated