Skip to content

Conversation

@MikeMcC399
Copy link
Contributor

Refs: #61427
Refs: nodejs/node-gyp#3264

Current documentation

The document section BUILDING > Windows Prerequisites > Option 1: Manual install provides the following instructions to install Python, that are correct only up to Python 3.13:

Manual install

The current version of Python from the Microsoft Store

Python has deprecated the full installer since version 3.14 and provides instead the Python Install Manager. The Microsoft Store displays only the versions Python 3.12 and 3.13.

The instructions in the node-gyp/README > On Windows repo documentation section have already been updated and now read:

Follow the instructions in Using Python on Windows to install the current version of Python on Windows.

Updated documentation

The updated node-gyp/README > On Windows instructions are copied to the node/BUILDING > Windows Prerequisites > Option 1: Manual install document section in this repo. This covers installing all Python 3 versions, including Python 3.14.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 18, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 18, 2026 13:23
Co-authored-by: Antoine du Hamel <[email protected]>
@MikeMcC399 MikeMcC399 requested a review from aduh95 January 19, 2026 08:14
@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 20, 2026
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/61428
✔  Done loading data for nodejs/node/pull/61428
----------------------------------- PR info ------------------------------------
Title      doc: update Python 3.14 manual install instructions (Windows) (#61428)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MikeMcC399:windows-python-install-doc -> nodejs:main
Labels     doc, build
Commits    2
 - doc: update Python 3.14 manual install instructions (Windows)
 - change to collapsed reference link
Committers 2
 - Mike McCready <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61428
Refs: https://github.com/nodejs/node/issues/61427
Refs: https://github.com/nodejs/node-gyp/issues/3264
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61428
Refs: https://github.com/nodejs/node/issues/61427
Refs: https://github.com/nodejs/node-gyp/issues/3264
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 18 Jan 2026 13:21:12 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61428#pullrequestreview-3675617552
   ✔  - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/61428#pullrequestreview-3677238708
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61428#pullrequestreview-3679855443
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61428#pullrequestreview-3681387656
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61428
From https://github.com/nodejs/node
 * branch                  refs/pull/61428/merge -> FETCH_HEAD
✔  Fetched commits as 87d7db191854..1f163f560525
--------------------------------------------------------------------------------
[main fe3231c2ec] doc: update Python 3.14 manual install instructions (Windows)
 Author: Mike McCready <[email protected]>
 Date: Sat Jan 17 08:41:08 2026 +0100
 1 file changed, 4 insertions(+), 2 deletions(-)
[main b4d0f097be] change to collapsed reference link
 Author: Mike McCready <[email protected]>
 Date: Sun Jan 18 17:03:09 2026 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:2262) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: update Python 3.14 manual install instructions (Windows)

PR-URL: #61428
Refs: #61427
Refs: nodejs/node-gyp#3264
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD 92627d45d4] doc: update Python 3.14 manual install instructions (Windows)
Author: Mike McCready <[email protected]>
Date: Sat Jan 17 08:41:08 2026 +0100
1 file changed, 4 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
change to collapsed reference link

Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #61428
Refs: #61427
Refs: nodejs/node-gyp#3264
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>

[detached HEAD efbe6bec7d] change to collapsed reference link
Author: Mike McCready <[email protected]>
Date: Sun Jan 18 17:03:09 2026 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/21173118685

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 20, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 20, 2026
@nodejs-github-bot nodejs-github-bot merged commit be44179 into nodejs:main Jan 20, 2026
35 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in be44179

@MikeMcC399 MikeMcC399 deleted the windows-python-install-doc branch January 20, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants