-
Notifications
You must be signed in to change notification settings - Fork 2
Docker build refreshment #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkijania
wants to merge
30
commits into
develop
Choose a base branch
from
dkijania/docker_refreshment
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,049
−816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Also do not rebuild auxiliary services just get release of them
b76f5aa to
c3c8638
Compare
9800771 to
896aee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refreshed how we build dockers for mina-lightnet-docker. Key changes:
removed entirely building mina for arm64/amd64 for lightnet and devnet. Instead used the ones which we should built in mina. (Mina PR: Add new configurations for mina-lightnet-docker MinaProtocol/mina#17794)
skip building mina-accounts manager and introduced release for them (https://github.com/shimkiv/mina-accounts-manager/releases/tag/v0.1.1)
skipped building archive-node-api and introduced release in its own repo: add release job Archive-Node-API#124
since we are using released or nightly versions of mina related packages, penalty for building arm64 using emulator is not so big therefore i avoided using hetzner cloud machine
As a result build time shrinked from
2h 5m 5sto12 minutes(amd64 - 2 minutes, arm64 - 12 minutes )Looking for guidance if we can publish dockers, now?