[IMP] runtime/utils: export htmlEscape and add tests #1677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seb-odoo
commented
Mar 25, 2025
seb-odoo
force-pushed
the
master-export-escape--seb
branch
from
6710049 to
23649ff
Compare
Contributor
|
hmm, it looks like you want to export the htmlescape function to use it out of owl. in that case, you forgot to expose it as an exported value. it should also be exported from here https://github.com/odoo/owl/blob/master/src/runtime/index.ts |
markup tag function requires markup awareness to determine whether a given parameter should be escaped or not. This implies that pre-escaped content should be properly marked'ed up to avoid double escaping. Having to manually wrap all calls to escape with markup is cumbersome and prone to issues (on top of having to be validated by the security team for no reason). This commit introduces a markup-aware escape function to resolve those issues.
seb-odoo
force-pushed
the
master-export-escape--seb
branch
from
23649ff to
5547bd7
Compare
ged-odoo
approved these changes
Mar 26, 2025
This was referenced Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markup tag function requires markup awareness to determine whether a given parameter should be escaped or not.
This implies that pre-escaped content should be properly marked'ed up to avoid double escaping. Having to manually wrap all calls to escape with markup is cumbersome and prone to issues (on top of having to be validated by the security team for no reason).
This commit introduces a markup-aware escape function to resolve those issues.