feat: support configuring volume size (k8s) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring the volume size is important, since deployments can vary greatly in size. This retains the 5Gi default volume size, but allows configuring it to suit the deployment. This is only relevant to k8s deployments; the docker deployments use a directory mounted from the host machine. Private-ref: https://tasks.opencraft.com/browse/BB-9977
bradenmacdonald
approved these changes
Oct 21, 2025
Member
bradenmacdonald
left a comment
bradenmacdonald
left a comment
There was a problem hiding this comment.
I can't easily test this on my devstack, but the change is small and makes sense - and I believe we're testing it on the sandbox anyways, so all good.
Member
Author
|
Thanks @bradenmacdonald . Yep, I've tested it on the typesense sandbox. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configuring the volume size is important,
since deployments can vary greatly in size.
This retains the 5Gi default volume size,
but allows configuring it to suit the deployment.
This is only relevant to k8s deployments;
the docker deployments use a directory mounted from the host machine.
Supporting information
Private-ref: https://tasks.opencraft.com/browse/BB-9977
Testing instructions
tutor config saveTYPESENSE_VOLUME_SIZEto something other than 5Gi in tutor's config.ymltutor config saveagainDeadline
None