Factor Responses into its own assembly #889
Open
+34,692
−660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
reviewed
Jan 10, 2026
Collaborator
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
I've got a PR out to move the repository configuration and package management to a centralized version, which would remove a lot of the redundancies that you needed in the project files and such.
christothes
requested review from
ShivangiReja and
joseharriaga
as code owners
KrzysztofCwalina
requested changes
Jan 27, 2026
| @@ -0,0 +1,7 @@ | |||
| using System.ClientModel.Primitives; | |||
|
|
|||
| namespace OpenAI; | |||
Collaborator
There was a problem hiding this comment.
can we not have any types in the root namespace in responses dll?
| @@ -0,0 +1,3 @@ | |||
| using System.Runtime.CompilerServices; | |||
|
|
|||
| [assembly: TypeForwardedTo(typeof(OpenAI.OpenAIClientOptions))] | |||
Collaborator
There was a problem hiding this comment.
we need a responses specific client options. we dont want to type forward.
| @@ -0,0 +1,100 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
Collaborator
There was a problem hiding this comment.
why do we need this new assembly if we create responses specific client options?
Collaborator
Author
There was a problem hiding this comment.
there are more shared helper types than just the options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.