-
Notifications
You must be signed in to change notification settings - Fork 360
Add implicit conversions to CodeInterpreterToolContainer union
#905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: joseharriaga <[email protected]>
CodeInterpreterToolContainer union
|
@copilot Can you sync to the latest and run the |
Done. Synced with main and ran |
|
@copilot I was looking at your work, and I didn't notice you running the
I believe you actually got it right even though you modified these files manually, so you might not see any diffs in the end, but it's good to do it the correct way to be safe. |
I reverted the changes to |
|
@copilot This is just a question: What can I do in the future to effectively provide you the necessary context for you to correctly use the |
A few suggestions that would help:
The key insight I was missing was understanding the relationship between the |
CodeInterpreterToolContainerthat were made toMcpToolCallApprovalPolicyin PR Add implicit conversions toMcpToolCallApprovalPolicyunion #901:[CodeGenVisibility(...)]attribute to generate the internal parameterless constructorArgument.AssertNotNullchecks in constructorsstring→CodeInterpreterToolContainer,CodeInterpreterToolContainerConfiguration→CodeInterpreterToolContainer)scripts/Export-Api.ps1(includes newOpenAI.net10.0.cs)scripts/Invoke-CodeGen.ps1Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.