Bump to version 1.0.0-alpha.20260116.3 - Add internal partial structs for new enums #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaiLinhP
requested review from
ShivangiReja,
christothes,
joseharriaga and
jsquire
as code owners
jorgerangel-msft
approved these changes
Jan 23, 2026
| // - Renamed. | ||
| // - Made internal until we support the convenience methods. | ||
| [CodeGenType("OrderEnum")] | ||
| internal readonly partial struct InternalOrderEnum |
Collaborator
There was a problem hiding this comment.
The only other tip / suggestion I have is to use the access decorator to set this type to internal. Though I don't see us using that anywhere else, so feel free to ignore and see what Jose thinks!
jorgerangel-msft
merged commit 0241d8e
into
openai:typespec/update-http-client-csharp-1.0.0-alpha.20260116.3
2 checks passed
jorgerangel-msft
pushed a commit
that referenced
this pull request
Jan 27, 2026
…lpha.20260116.3 (#900) * Update @typespec/http-client-csharp to 1.0.0-alpha.20260116.3 - Updated @typespec/http-client-csharp from 1.0.0-alpha.20260111.1 to 1.0.0-alpha.20260116.3 - Updated Microsoft.TypeSpec.Generator.ClientModel from 1.0.0-alpha.20260111.1 to 1.0.0-alpha.20260116.3 - Regenerated OpenAI SDK code with new generator version - Updated centrally managed package-lock.json file with new dependency versions * Bump to version 1.0.0-alpha.20260116.3 - Add internal partial structs for new enums (#907) * Add internal partial structs for new enums * Remove custom code that causes duplication in generated code --------- Co-authored-by: Linh Phan <[email protected]> * Delete IncludedConversationItemProperty custom code that can be generated (#919) * Add internal partial structs for new enums * Remove custom code that causes duplication in generated code * Delete custom implementation that can be generated --------- Co-authored-by: Linh Phan <[email protected]> --------- Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Linh Phan <[email protected]> Co-authored-by: Linh Phan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made enums internal to fix build issues