[EngSys] Replace GenAPI tool with GenAPI MSBuild task in Export-Api.ps1 #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@copilot Modify the Export-Api.ps1 script in this PR so that it deletes the contents of the "api" folder before running the GenAPI task. |
Contributor
|
@joseharriaga I've opened a new pull request, #910, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Delete api folder contents before running GenAPI Co-authored-by: joseharriaga <[email protected]> * Add error handling and recursive cleanup for api folder Co-authored-by: joseharriaga <[email protected]> * Optimize api folder cleanup command Co-authored-by: joseharriaga <[email protected]> * Use Join-Path for cross-platform compatibility Co-authored-by: joseharriaga <[email protected]> * Ensure cleanup includes hidden files Co-authored-by: joseharriaga <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: joseharriaga <[email protected]>
Collaborator
Author
|
@copilot Simplify the changes in this PR by taking the following into consideration:
|
Contributor
|
@joseharriaga I've opened a new pull request, #911, to work on those changes. Once the pull request is ready, I'll request review from you. |
… parameters (#911) - **Removed `Configuration` parameter** - Now hardcoded to "Release" - **Removed `TargetFramework` parameter** - Always processes all TFMs from `ClientTargetFrameworks` in Directory.Build.props - **Updated script documentation** - Removed parameter documentation and examples to reflect single-purpose behavior - **Fixed MSBuild invocation** - Modified script to explicitly iterate over each target framework (net10.0, net8.0, netstandard2.0) to ensure the ExportApi MSBuild target runs correctly for multi-targeted projects
Collaborator
Author
|
@copilot The current Export-Api.ps1 script in this PR runs |
Merged
Contributor
|
@joseharriaga I've opened a new pull request, #918, to work on those changes. Once the pull request is ready, I'll request review from you. |
- **MSBuild Integration**: Added `ExportApi` target in `Directory.Build.targets` that uses an outer/inner build pattern to automatically handle all target frameworks - **Outer build target**: Dispatches to inner builds for each target framework when building a multi-targeted project - **Inner build target** (`ExportApiInner`): Invokes GenAPITask for each specific target framework - **Export Script**: Created `Export-Api.ps1` PowerShell script that: - Cleans the `api/` folder before generation - Runs a single build command with the `ExportApi` target (MSBuild automatically handles all TFMs: net10.0, net8.0, netstandard2.0) - Post-processes generated files to remove fully-qualified names, internal APIs, and unwanted attributes - Always uses Release configuration
joseharriaga
changed the title
joseharriaga
requested review from
ShivangiReja,
christothes and
jsquire
as code owners
jsquire
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.