Skip to content

Conversation

@SOHAMPAL23
Copy link

@SOHAMPAL23 SOHAMPAL23 commented Jan 8, 2026

Pull Request

  • Add self-supervised AI-based data assimilation using 3D-Var loss

Description

  • This PR introduces a self-supervised AI-based data assimilation prototype

  • The implementation replaces supervised learning with a physics-based 3D-Var cost function, allowing the model to learn directly from:

  • Sparse/noisy observations

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

@SOHAMPAL23 SOHAMPAL23 changed the title A iasm Add self-supervised 3D-Var-based AI data assimilation Jan 8, 2026
@SOHAMPAL23
Copy link
Author

Hey @jacobbieker Can you check this pr

@jacobbieker jacobbieker self-requested a review January 8, 2026 06:58
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for some simplication. Please look at the comments made on the previous PR, they aren't all addressed in this one.

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing some of the comments, but you haven't addressed them all or fixed the changes I've asked for. Please do that before requesting my review again.

@SOHAMPAL23
Copy link
Author

Hey @jacobbieker Can You now give review on this

@Sidharth1743
Copy link
Contributor

@SOHAMPAL23 use the review button. don't tag him. it will be notified in that way itself. thanks:)

@SOHAMPAL23
Copy link
Author

@Sidharth1743 Thanks for letting me know that.

So Till he reviews it, I can work on other issues

Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make sure your newly added code passes the linting? It will need more docstrings at least that I can see. I know running the pre-commit throws a lot of errors, but I just care about this newly added code passing those linting steps as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants