-
-
Notifications
You must be signed in to change notification settings - Fork 92
Add self-supervised 3D-Var-based AI data assimilation #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
|
Hey @jacobbieker Can you check this pr |
jacobbieker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for some simplication. Please look at the comments made on the previous PR, they aren't all addressed in this one.
jacobbieker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing some of the comments, but you haven't addressed them all or fixed the changes I've asked for. Please do that before requesting my review again.
|
Hey @jacobbieker Can You now give review on this |
|
@SOHAMPAL23 use the review button. don't tag him. it will be notified in that way itself. thanks:) |
|
@Sidharth1743 Thanks for letting me know that. So Till he reviews it, I can work on other issues |
jacobbieker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure your newly added code passes the linting? It will need more docstrings at least that I can see. I know running the pre-commit throws a lot of errors, but I just care about this newly added code passing those linting steps as well.
for more information, see https://pre-commit.ci
Pull Request
Description
This PR introduces a self-supervised AI-based data assimilation prototype
The implementation replaces supervised learning with a physics-based 3D-Var cost function, allowing the model to learn directly from:
Sparse/noisy observations
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist:
[Paper] AI-based Data Assimilation #173