Process,Config: use pointer receivers #5088
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Config type is quite big (currently 554 bytes on a 64 bit Linux) and using non-pointer receivers in its methods results in copying which is totally unnecessary. Change the methods to use pointer receivers. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The Process type is quite big (currently 368 bytes on a 64 bit Linux) and using non-pointer receivers in its methods results in copying which is totally unnecessary. Change the methods to use pointer receivers. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
rata
approved these changes
Jan 23, 2026
Member
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Just curious, is there some metric you care about that is improved with this or it's just a "Looking at the code I realized we are doing this, this is wasteful, let's avoid it"?
About the linter, do as you think it is best, fixing it doesn't seem hard... Although not sure I like the suggestion 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config and Process types are quite big (currently 554 and 368 bytes on a 64 bit Linux),
so using non-pointer receivers in its methods results in copying which
is totally unnecessary.
Change their methods to use pointer receivers.