Skip to content

Conversation

@streino
Copy link
Contributor

@streino streino commented Sep 8, 2025

Solution for #846 (comment)

Turns out we were not even restarting on base config...

@JeSuisUnCaillou
Copy link
Collaborator

This is still a draft, should we wait to review ?

@JeSuisUnCaillou
Copy link
Collaborator

JeSuisUnCaillou commented Sep 8, 2025

Turns out we were not even restarting on base config...

I'm 84% sure I tried on the main branch to change a config and the hot reload was watching it. Let me retry... Yeah, I confirm that modifying the config on the main doesn't require a restart of the dev server to be taking into account.

(I'll look into your solution anyway 😉 )

Copy link
Collaborator

@JeSuisUnCaillou JeSuisUnCaillou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit to me 👍

We can merge this into #846 then into #828, and I'll work on the rebase then.

@streino
Copy link
Contributor Author

streino commented Sep 8, 2025

This is still a draft, should we wait to review ?

It's really just a proposal so I figured "draft" was appropriate. Feel free to pull it into your PR if you find it useful.

Turns out we were not even restarting on base config...

I'm 84% sure I tried on the main branch to change a config and the hot reload was watching it. Let me retry... Yeah, I confirm that modifying the config on the main doesn't require a restart of the dev server to be taking into account.

Right... Works for me as well. I used the wrong branch to test :/
We likely broke auto-reload by replacing the file config with a string, meaning there's no more import config from '@siteConfig/config.yaml' that knows when to trigger a reload.

@JeSuisUnCaillou JeSuisUnCaillou marked this pull request as ready for review September 12, 2025 07:32
@JeSuisUnCaillou JeSuisUnCaillou merged commit 1ef66d4 into chore/merge-config-build Sep 12, 2025
7 of 8 checks passed
@JeSuisUnCaillou JeSuisUnCaillou deleted the chore/restart-on-config-change branch September 12, 2025 07:33
JeSuisUnCaillou pushed a commit that referenced this pull request Sep 12, 2025
* chore: merge config at build time

* comment

* Use ViteRestart to detect config changes (#865)

---------

Co-authored-by: streino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants