-
Notifications
You must be signed in to change notification settings - Fork 5
Use ViteRestart to detect config changes #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ViteRestart to detect config changes #865
Conversation
|
This is still a draft, should we wait to review ? |
I'm 84% sure I tried on the main branch to change a config and the hot reload was watching it. Let me retry... Yeah, I confirm that modifying the config on the main doesn't require a restart of the dev server to be taking into account. (I'll look into your solution anyway 😉 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's really just a proposal so I figured "draft" was appropriate. Feel free to pull it into your PR if you find it useful.
Right... Works for me as well. I used the wrong branch to test :/ |
1ef66d4
into
chore/merge-config-build
* chore: merge config at build time * comment * Use ViteRestart to detect config changes (#865) --------- Co-authored-by: streino <[email protected]>
Solution for #846 (comment)
Turns out we were not even restarting on base config...