MGMT-20398: Block host install if Ironic Agent is not completed #8743

CrystalChun · 2026-01-12T16:43:00Z

In kube-api there are instances where a user might manually start the assisted installer agent before the Ironic Agent completes all that it needs to do. This leads to the host installing incorrectly.

To prevent this, we'll block the installation from starting until we know that Ironic Agent has completed if it is enabled.
If it's not enabled, the install should progress as normal.

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Manual testing

With converged flow enabled

Blocking install

Create late-binding BMH and InfraEnv with Ironic agent override image set to an incompatible CPU architecture (arm64) for amd64 machine

    annotations:
      infraenv.agent-install.openshift.io/ironic-agent-image-override: quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:3d99b3160fad7da23af2f9dcee8a9804d3f23858f22b09ad1e1606fff80e756d

Observe the BMH stuck in inspecting, log into host and start the assisted-service agent manually
Attach Agent to cluster
Observe that the Agent does not start installing and the BMH is stuck in inspecting

Happy flow

Create late-binding BMH and InfraEnv with correct ironic image
Observe the BMH move to provisioning and ironic agent finishing inspecting and starting assisted agent
When the agent appears, bind it to a cluster
Observe that the Agent starts and finishes installing as usual

Regression test without BMH

Create InfraEnv and boot host from discovery ISO
Observe Agent appearing
Bind Agent to cluster
Observe the Agent start and finish installation

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot · 2026-01-12T16:43:04Z

coderabbitai · 2026-01-12T16:43:06Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-01-12T16:43:08Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

CrystalChun · 2026-01-12T16:43:10Z

/test ?

openshift-ci · 2026-01-12T16:43:25Z

@CrystalChun: The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4

/test edge-assisted-operator-catalog-publish-verify

/test edge-ci-index

/test edge-e2e-ai-operator-disconnected-capi

/test edge-e2e-ai-operator-ztp

/test edge-e2e-ai-operator-ztp-3masters

/test edge-e2e-ai-operator-ztp-capi

/test edge-e2e-ai-operator-ztp-disconnected

/test edge-e2e-metal-assisted-4-16

/test edge-e2e-metal-assisted-4-17

/test edge-e2e-metal-assisted-4-20

/test edge-e2e-metal-assisted-5-control-planes-4-20

/test edge-e2e-metal-assisted-external-4-20

/test edge-e2e-metal-assisted-lvm-4-20

/test edge-e2e-metal-assisted-none-4-20

/test edge-e2e-metal-assisted-openshift-ai-4-18

/test edge-e2e-metal-assisted-osc-4-20

/test edge-e2e-metal-assisted-virtualization-4-19

/test edge-e2e-metal-assisted-vlan-4-20

/test edge-e2e-vsphere-assisted-4-20

/test edge-images

/test edge-lint

/test edge-operator-publish-verify

/test edge-subsystem-aws

/test edge-subsystem-kubeapi-aws

/test edge-unit-test

/test edge-verify-generated-code

/test images

/test mce-images

/test okd-scos-images

/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4

/test e2e-agent-5control-ipv4

/test e2e-agent-ha-dualstack

/test e2e-agent-sno-ipv6

/test edge-e2e-ai-operator-ztp-4masters

/test edge-e2e-ai-operator-ztp-5masters

/test edge-e2e-ai-operator-ztp-compact-day2-masters

/test edge-e2e-ai-operator-ztp-compact-day2-workers

/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp

/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp

/test edge-e2e-ai-operator-ztp-node-labels

/test edge-e2e-ai-operator-ztp-remove-node

/test edge-e2e-ai-operator-ztp-sno-day2-masters

/test edge-e2e-ai-operator-ztp-sno-day2-workers

/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride

/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding

/test edge-e2e-metal-assisted-4-control-planes-4-20

/test edge-e2e-metal-assisted-4-masters-none-4-20

/test edge-e2e-metal-assisted-bond-4-20

/test edge-e2e-metal-assisted-day2-4-20

/test edge-e2e-metal-assisted-day2-arm-workers-4-20

/test edge-e2e-metal-assisted-day2-sno-4-20

/test edge-e2e-metal-assisted-dual-primary-v6-compact-4-20

/test edge-e2e-metal-assisted-dual-stack-primary-ipv6-4-20

/test edge-e2e-metal-assisted-ha-kube-api-ipv4-4-20

/test edge-e2e-metal-assisted-ha-kube-api-ipv6-4-20

/test edge-e2e-metal-assisted-ipv4v6-4-20

/test edge-e2e-metal-assisted-ipv6-4-20

/test edge-e2e-metal-assisted-kube-api-late-binding-sno-4-20

/test edge-e2e-metal-assisted-kube-api-late-unbinding-sno-4-20

/test edge-e2e-metal-assisted-kube-api-umlb-4-20

/test edge-e2e-metal-assisted-onprem-4-20

/test edge-e2e-metal-assisted-osc-sno-4-20

/test edge-e2e-metal-assisted-sno-4-20

/test edge-e2e-metal-assisted-static-ip-suite-4-20

/test edge-e2e-metal-assisted-tang-4-20

/test edge-e2e-metal-assisted-tpmv2-4-20

/test edge-e2e-metal-assisted-umlb-4-20

/test edge-e2e-metal-assisted-upgrade-agent-4-20

/test edge-e2e-oci-assisted-4-20

/test edge-e2e-oci-assisted-bm-iscsi-4-20

/test edge-e2e-vsphere-assisted-umlb-4-20

/test edge-e2e-vsphere-assisted-umn-4-20

/test okd-scos-e2e-aws-ovn

/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4

pull-ci-openshift-assisted-service-master-edge-ci-index

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp

pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp-capi

pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-20

pull-ci-openshift-assisted-service-master-edge-images

pull-ci-openshift-assisted-service-master-edge-lint

pull-ci-openshift-assisted-service-master-edge-subsystem-aws

pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws

pull-ci-openshift-assisted-service-master-edge-unit-test

pull-ci-openshift-assisted-service-master-edge-verify-generated-code

pull-ci-openshift-assisted-service-master-images

pull-ci-openshift-assisted-service-master-mce-images

pull-ci-openshift-assisted-service-master-okd-scos-images

pull-ci-openshift-assisted-service-master-verify-deps

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

CrystalChun · 2026-01-12T16:44:43Z

/test edge-subsystem-kubeapi-aws edge-subsystem-aws

openshift-ci · 2026-01-12T16:45:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CrystalChun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

CrystalChun · 2026-01-12T19:48:26Z

/test edge-subsystem-kubeapi-aws edge-subsystem-aws

CrystalChun · 2026-01-12T20:28:20Z

/test edge-subsystem-kubeapi-aws edge-subsystem-aws

CrystalChun · 2026-01-12T22:17:01Z

/test edge-subsystem-kubeapi-aws edge-subsystem-aws

CrystalChun · 2026-01-12T22:37:59Z

/test edge-subsystem-kubeapi-aws edge-subsystem-aws

openshift-ci-robot · 2026-01-12T23:48:05Z

CrystalChun · 2026-01-13T02:21:15Z

/cc @carbonin

codecov · 2026-01-13T02:39:23Z

Codecov Report

❌ Patch coverage is 15.87302% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.52%. Comparing base (13a784a) to head (2faea21).

⚠️ Current head 2faea21 differs from pull request most recent head 8258b3a

Please upload reports for the commit 8258b3a to get more accurate results.

Files with missing lines	Patch %	Lines
restapi/embedded_spec.go	0.00%	40 Missing ⚠️
...nternal/controller/controllers/agent_controller.go	23.52%	35 Missing and 4 partials ⚠️
internal/host/host.go	0.00%	15 Missing ⚠️
internal/bminventory/inventory.go	44.44%	8 Missing and 2 partials ⚠️
internal/host/hostcommands/install_cmd.go	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8743      +/-   ##
==========================================
- Coverage   43.82%   43.52%   -0.31%     
==========================================
  Files         414      412       -2     
  Lines       71747    71649      -98     
==========================================
- Hits        31443    31185     -258     
- Misses      37447    37660     +213     
+ Partials     2857     2804      -53

Files with missing lines	Coverage Δ
internal/host/hostcommands/install_cmd.go	`83.33% <0.00%> (-0.50%)`	⬇️
internal/bminventory/inventory.go	`71.88% <44.44%> (-0.11%)`	⬇️
internal/host/host.go	`72.39% <0.00%> (-1.19%)`	⬇️
...nternal/controller/controllers/agent_controller.go	`75.74% <23.52%> (-0.85%)`	⬇️
restapi/embedded_spec.go	`0.00% <0.00%> (ø)`

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CrystalChun · 2026-01-13T05:34:37Z

/retest-required

openshift-ci · 2026-01-13T08:28:19Z

@CrystalChun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Allows tracking the status of the ironic agent through the host model.

If a host requests to install, we'll first check if Ironic is either complete or not required. If it is required and still in progress, then we'll error out before sending that command to the host.

If the converged flow is enabled, then we set the status to `in_progress` if the BMH is not provisioning or provisioned or to `completed` otherwise. If the converged flow is not enabled, then the status is set to `not_required`.

Reducing the cyclomatic complexity of updateIfNeeded function

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2026

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2026

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 12, 2026

openshift-ci bot added the api-review Categorizes an issue or PR as actively needing an API review. label Jan 12, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026

CrystalChun force-pushed the split-brain branch from e69d9fe to b4a9fee Compare January 12, 2026 17:10

openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 12, 2026

CrystalChun force-pushed the split-brain branch from 29b80a8 to 85e8081 Compare January 12, 2026 20:28

CrystalChun force-pushed the split-brain branch 3 times, most recently from a73f408 to a660c71 Compare January 12, 2026 22:11

CrystalChun force-pushed the split-brain branch from a660c71 to 2faea21 Compare January 12, 2026 22:37

CrystalChun marked this pull request as ready for review January 13, 2026 02:21

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 13, 2026

openshift-ci bot requested review from carbonin and danielerez January 13, 2026 02:21

openshift-ci bot requested a review from eranco74 January 13, 2026 02:22

CrystalChun marked this pull request as draft January 14, 2026 22:08

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2026

CrystalChun added 4 commits January 15, 2026 09:51

MGMT-20398: Add ironic agent status to host

69563c7

Allows tracking the status of the ironic agent through the host model.

MGMT-20398: Block host install command if Ironic is not complete

bf47d1d

If a host requests to install, we'll first check if Ironic is either complete or not required. If it is required and still in progress, then we'll error out before sending that command to the host.

MGMT-20398: Add or update ironic agent status in host

eabfbd2

If the converged flow is enabled, then we set the status to `in_progress` if the BMH is not provisioning or provisioned or to `completed` otherwise. If the converged flow is not enabled, then the status is set to `not_required`.

MGMT-20398: Move ignitionEndpointHTTPHeaders to separate function

8258b3a

Reducing the cyclomatic complexity of updateIfNeeded function

CrystalChun force-pushed the split-brain branch from 2faea21 to 8258b3a Compare January 15, 2026 15:51

MGMT-20398: Block host install if Ironic Agent is not completed #8743

Are you sure you want to change the base?

MGMT-20398: Block host install if Ironic Agent is not completed #8743

Uh oh!

Conversation

CrystalChun commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Manual testing

Blocking install

Happy flow

Regression test without BMH

Checklist

Reviewers Checklist

Uh oh!

openshift-ci-robot commented Jan 12, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

Uh oh!

coderabbitai bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci bot commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

openshift-ci bot commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

openshift-ci bot commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

CrystalChun commented Jan 12, 2026

Uh oh!

openshift-ci-robot commented Jan 12, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Manual testing

Blocking install

Happy flow

Regression test without BMH

Checklist

Reviewers Checklist

Uh oh!

CrystalChun commented Jan 13, 2026

Uh oh!

codecov bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CrystalChun commented Jan 13, 2026

Uh oh!

openshift-ci bot commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CrystalChun commented Jan 12, 2026 •

edited

Loading

openshift-ci-robot commented Jan 12, 2026 •

edited by openshift-ci bot

Loading

coderabbitai bot commented Jan 12, 2026 •

edited

Loading

openshift-ci-robot commented Jan 12, 2026 •

edited by openshift-ci bot

Loading

codecov bot commented Jan 13, 2026 •

edited

Loading