luci-app-advanced-reboot: bugfix: actual partition switch #8239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point after r7, when I no longer had the dual boot device readily available for testing, a regression was introduced that the RPCD script would not actually perform the partition switch. Thanks to @bd0426 for report and @Jackie264 for fixing the issue. advanced-reboot.js * simplify partition number validation in handleAlternativeReboot * reformat text copy RPCD script * obtain OpenWrt version from "$OPENWRT_RELEASE" not "$PRETTY_NAME" for the snapshot compatibility * refactor parameter processing for boot_partition function * add logging/better output on error in boot_partition test.sh * introduce a test file for heartbeat check of the RPCD script Signed-off-by: Stan Grishin <stangri@melmac.ca>
Failed checksIssues marked with an ❌ are failing checks. Commit 6b27116
For more details, see the full job log. Something broken? Consider providing feedback. |
|
@systemcrash Please merge this PR, thanks! |
systemcrash
reviewed
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: x86_64, Dell EMC Edge 620, OpenWrt 24.10.4
Run tested: x86_64, Dell EMC Edge 620, OpenWrt 24.10.4
Description:
At some point after r7, when I no longer had the dual boot device readily available for testing, a regression was introduced that the RPCD script would not actually perform the partition switch.
Thanks to @bd0426 for report and @Jackie264 for fixing the issue.
advanced-reboot.js
RPCD script
test.sh