[#69553] Remove jQuery from CKEditor build [FIXUP] #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myabc
changed the title
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 19, 2026
Built from upstream commit: 122e338255f254940dc02a5c2e72681e8d9c5d37 See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes broken mentions (work package and user) and previews that resulted from the jQuery removal in PR #107. The fix replaces native fetch() calls with Rails Request.JS, which automatically handles CSRF token headers required by the Rails backend.
Changes:
- Added
@rails/request.jsas a dependency for CSRF-aware HTTP requests - Replaced
fetch()with Request.JSget()andpost()functions in three files - Updated documentation to reflect the use of Request.JS instead of raw Fetch API
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added @rails/request.js dependency and React peer dependency |
| package-lock.json | Lock file updates for new dependencies |
| src/plugins/op-preview.plugin.js | Replaced fetch() with Request.JS post() for preview functionality |
| src/mentions/work-package-mentions.js | Replaced fetch() with Request.JS get() for work package autocomplete |
| src/mentions/user-mentions.js | Replaced fetch() with Request.JS get() for user mentions |
| README.md | Updated documentation to mention Request.JS instead of Fetch API |
| CHANGELOG.md | Updated changelog to reflect Request.JS usage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myabc
force-pushed
the
code-maintenance/69553-rid-jquery-ckeditor-fixup
branch
from
122e338 to
509e734
Compare
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 19, 2026
Built from upstream commit: 509e73464638e45f84d0b713089ea31b8cfb3ced See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
Request.JS provides a wrapper around `fetch`, taking care of setting the `X-CSRF-Token` header.
myabc
force-pushed
the
code-maintenance/69553-rid-jquery-ckeditor-fixup
branch
from
509e734 to
7795208
Compare
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 19, 2026
Built from upstream commit: 7795208016d3efbf1cd8545aa852824fd2f3b149 See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
3 tasks
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 20, 2026
Built from upstream commit: 7795208016d3efbf1cd8545aa852824fd2f3b149 See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
akabiru
approved these changes
Jan 20, 2026
Member
akabiru
left a comment
akabiru
left a comment
There was a problem hiding this comment.
Looking good to me! Just one question
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 20, 2026
Built from upstream commit: ec8c1b8b1a0a858467fdd4f15a761a25fd85f801 See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
myabc
added a commit
to opf/openproject
that referenced
this pull request
Jan 20, 2026
Built from upstream commit: ec8c1b8b1a0a858467fdd4f15a761a25fd85f801 See upstream PRs: - opf/commonmark-ckeditor-build#107 - opf/commonmark-ckeditor-build#108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Follow on from #107
Ticket
https://community.openproject.org/wp/69553
What are you trying to accomplish?
Fixes broken mentions (work package, user) and previews.
In detail:
What approach did you choose and why?
I went with Rails Request.JS as we are already using it in core. It takes care of setting
X-CSRF-Tokenheaders automatically.Merge checklist