[68833] Show document as separate tab on mobile #21686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HDinger
changed the title
HDinger
force-pushed
the
code-maintenance/68833-provide-a-standardized-page-layout-for-full-view-pages-like-document-full-view-2
branch
from
67c9b45 to
e0325df
Compare
HDinger
force-pushed
the
code-maintenance/68833-provide-a-standardized-page-layout-for-full-view-pages-like-document-full-view-2
branch
from
e0325df to
53401fe
Compare
…-page-layout-for-full-view-pages-like-document-full-view-2
akabiru
approved these changes
Jan 22, 2026
Member
akabiru
left a comment
akabiru
left a comment
There was a problem hiding this comment.
I tested the layout and it's looking good! I think it's amazing that the code footprint is relatively small 🥇
modules/documents/app/components/documents/show_edit_view/block_note_editor_component.rb
Outdated
Show resolved
Hide resolved
modules/documents/app/components/documents/show_edit_view/page_layout_component.rb
Show resolved
Hide resolved
…-page-layout-for-full-view-pages-like-document-full-view-2
…-page-layout-for-full-view-pages-like-document-full-view-2
HDinger
deleted the
code-maintenance/68833-provide-a-standardized-page-layout-for-full-view-pages-like-document-full-view-2
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/68833
What are you trying to accomplish?
In the new documents module, the mobile behaviour should be changed: Instead of showing the attachment tab (and future additional tabs) below the document, the TabNav should be extended by an additional tab called "Document". That new tab is shown at the first position.
Screenshots
Mobile
Tablet
Desktop
(small)
Desktop (large)
What approach did you choose and why?
The component relies on the browser gem to detect mobile and tablet device. That has two consequences:
I decided for this approach, as the solution is much cleaner. A CSS only solution would require heavy inteference with the Primer components, while the way it is done now, just uses the Primer components by design