bootc-generic-iso: add container embedding #2138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejbudai
force-pushed
the
bootc-embedding
branch
from
b9ffffc to
d04d35a
Compare
ondrejbudai
force-pushed
the
bootc-embedding
branch
from
d04d35a to
6d34afa
Compare
Member
Author
|
Yes, let's add it to the list of our ideas. :) I fixed the manifest checksums, it ended up being a bigger fix than I would like but it actually makes the code cleaner. |
validate-config-list is extremely weird with bootc distros. It works for empty.json with bootc-* only because it finds some random image type coming from package mode. However, if we introduce configs that target specific bootc image types that don't have the same name as one of the package mode image type, this simply blows up because it won't find anything. Thus, as this check clearly doesn't target bootc distros, let's ignore them altogether.
Prior this commit, we mutated the build config (empty.json) when the fake containers yaml specified a payload container image. As the build config struct was shared between all fake containers, this meant the the payload container image would get propagated also to image types that don't need it. This issue manifested in the next commit after this where I add support for a payload container image for bootc-generic-iso. It added the payload even if it was not specified in the fake containers yaml because of the mutation. This commit removes the mutation. Instead, we now have a separate config for the bootc-installer which contains the payload container ref. This way, the mutation is no longer needed.
In order to produce an offline installer, we need to embed the bootc payload container into the containers storage of the ISO. This commit reuses --bootc-installer-payload-ref to do it. This means that we can currently embed only a single commit, which is something we should try to generalize in the future: I see no reason why people couldn't embed more of them.
ondrejbudai
force-pushed
the
bootc-embedding
branch
from
6d34afa to
409687c
Compare
supakeen
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to produce an offline installer, we need to embed the bootc payload container into the containers storage of the ISO. This commit reuses --bootc-installer-payload-ref to do it. This means that we can currently embed only a single commit, which is something we should try to generalize in the future: I see no reason why people couldn't embed more of them.