-
Notifications
You must be signed in to change notification settings - Fork 77
rpmkeys tweaks #2152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
croissanne
wants to merge
9
commits into
osbuild:main
Choose a base branch
from
croissanne:rpmkeys
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
rpmkeys tweaks #2152
+809
−528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks is a new object in the distro definitions that is means to be used for defining build configuration options that aren't tied to an image definition (or ImageConfig), but are required to make the build work. It currently defines one sub-struct with two options. The options will be used to define the behaviour of the RPM stages when handling PQC keys. See osbuild/osbuild#2310 and HMS-10057 for information on why these are needed. Currently the object is only defined on the distro yaml. It can also be added on the image type later if needed and merged with the distro config for image-type-specific overrides. The options, in the current commit, have no effect.
Not all RHEL-like distros will have PQC keys.
achilleas-k
reviewed
Jan 22, 2026
Member
achilleas-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the manifest checksum changes into the commit that caused them to change? It's nice to always know which commit affected the image definitions by seeing the checksums change alongside them.
1f00db3 to
0f4bd3b
Compare
achilleas-k
reviewed
Jan 23, 2026
Include pqrpm in the buildroot on rhel distros.
Up until now build pipeline options were set per image. In order to make tweaks to the build pipeline per distribution, options from the distro yaml need to be propagated to the images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.