Add global type assertion for QQ and ZZ #918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederc
approved these changes
Dec 23, 2025
This requires moving the `__init__` method until after `Integers`
and `Rationals` are defined, so I simply moved it to the end of
the file.
Fixes genuine type instability, and silence the warnings reported by
using Singular, JET; Qt,t = QQ[:t]; @report_opt t+t
fingolfin
force-pushed
the
mh/type-assert-QQ-ZZ
branch
from
876367a to
ac02870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires moving the
__init__method until afterIntegersand
Rationalsare defined, so I simply moved it to the end ofthe file.
Fixes genuine type instability, and silence the warnings reported by