Skip to content

Conversation

@nabim777
Copy link
Member

@nabim777 nabim777 commented Dec 31, 2025

Description

Rewrite the old Cucumber test from shares/Share.feature with a only Playwright test.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@nabim777 nabim777 self-assigned this Dec 31, 2025
@nabim777 nabim777 force-pushed the tests/shareFeature branch 2 times, most recently from 759793f to 0688cd6 Compare January 2, 2026 09:22
@nabim777 nabim777 force-pushed the tests/shareFeature branch from 399a512 to 98497d7 Compare January 2, 2026 11:04
@nabim777 nabim777 force-pushed the tests/shareFeature branch 5 times, most recently from 70ecca0 to dc59c33 Compare January 13, 2026 10:27
@nabim777 nabim777 marked this pull request as ready for review January 15, 2026 05:02
@nabim777 nabim777 requested review from anon-pradip, nirajacharya2 and saw-jan and removed request for saw-jan January 15, 2026 05:03
// | folder_to_shared | Brian | user | Can edit without versions | folder |
// | shared_folder | Brian | user | Can edit without versions | folder |
// | folder_to_shared_2 | Brian | user | Can edit without versions | folder |
await ui.shareResource({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can pass multiple resources in an array:

await ui.shareResource({
      actorsEnvironment,
      usersEnvironment,
      stepUser: 'Alice',
      resources:[ 'shared_folder','folder_to_shared', 'shared_folder', 'folder_to_shared_2']
      resourceType: 'folder',
      recipient: 'Brian',
      role: 'Can edit without versions',
      actions: 'SIDEBAR_PANEL'
    })

instead of calling the same function multiple times for different resources

Copy link
Member Author

@nabim777 nabim777 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, if the data table's column headers (user, recipient, role, or actions) have different values, then using an array may not be appropriate and could cause confusion.

// | folder_to_shared | Brian | user | Can edit without versions | folder |
// | shared_folder | Brian | user | Can edit without versions | folder |
// | folder_to_shared_2 | Brian | user | Can edit without versions | folder |
await ui.shareResource({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can pass multiple resources in an array:

await ui.shareResource({
      actorsEnvironment,
      usersEnvironment,
      stepUser: 'Alice',
      resources:[ 'shared_folder','folder_to_shared', 'shared_folder', 'folder_to_shared_2']
      resourceType: 'folder',
      recipient: 'Brian',
      role: 'Can edit without versions',
      actions: 'SIDEBAR_PANEL'
    })

instead of calling the same function multiple times for different resources

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment applies here #13432 (comment)

@nabim777 nabim777 force-pushed the tests/shareFeature branch 2 times, most recently from e26cc27 to 11ec503 Compare January 15, 2026 11:37
Signed-off-by: nabim777 <[email protected]>
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants