-
Notifications
You must be signed in to change notification settings - Fork 196
[full-ci][tests-only] rewrite share feature file into playwright only #13432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
759793f to
0688cd6
Compare
0688cd6 to
98b7b0c
Compare
399a512 to
98497d7
Compare
70ecca0 to
dc59c33
Compare
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
Signed-off-by: nabim777 <[email protected]>
dc59c33 to
1a4a7cb
Compare
| // | folder_to_shared | Brian | user | Can edit without versions | folder | | ||
| // | shared_folder | Brian | user | Can edit without versions | folder | | ||
| // | folder_to_shared_2 | Brian | user | Can edit without versions | folder | | ||
| await ui.shareResource({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can pass multiple resources in an array:
await ui.shareResource({
actorsEnvironment,
usersEnvironment,
stepUser: 'Alice',
resources:[ 'shared_folder','folder_to_shared', 'shared_folder', 'folder_to_shared_2']
resourceType: 'folder',
recipient: 'Brian',
role: 'Can edit without versions',
actions: 'SIDEBAR_PANEL'
})
instead of calling the same function multiple times for different resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, if the data table's column headers (user, recipient, role, or actions) have different values, then using an array may not be appropriate and could cause confusion.
| // | folder_to_shared | Brian | user | Can edit without versions | folder | | ||
| // | shared_folder | Brian | user | Can edit without versions | folder | | ||
| // | folder_to_shared_2 | Brian | user | Can edit without versions | folder | | ||
| await ui.shareResource({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can pass multiple resources in an array:
await ui.shareResource({
actorsEnvironment,
usersEnvironment,
stepUser: 'Alice',
resources:[ 'shared_folder','folder_to_shared', 'shared_folder', 'folder_to_shared_2']
resourceType: 'folder',
recipient: 'Brian',
role: 'Can edit without versions',
actions: 'SIDEBAR_PANEL'
})
instead of calling the same function multiple times for different resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment applies here #13432 (comment)
e26cc27 to
11ec503
Compare
Signed-off-by: nabim777 <[email protected]>
11ec503 to
c7dcdde
Compare
|



Description
Rewrite the old Cucumber test from shares/Share.feature with a only Playwright test.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: