[full-ci][tests-only] test: migrate groups.feature to playwright #13472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
from
8a79e35 to
20fe508
Compare
53 tasks
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
3 times, most recently
from
25fc463 to
8198f8e
Compare
anon-pradip
commented
Jan 13, 2026
| ), | ||
| page.locator(compareDialogConfirm).click() | ||
| ]) | ||
| await objects.a11y.Accessibility.assertNoSevereA11yViolations( |
Contributor
Author
There was a problem hiding this comment.
Toast doesn't appear hereafter so not checking the whole body
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
3 times, most recently
from
ade95bc to
d42ee93
Compare
anon-pradip
requested review from
Ashim-Stha,
Salipa-Gurung,
kavitagautam,
nabim777,
nirajacharya2 and
saw-jan
| And "Admin" logs in | ||
| And "Admin" opens the "admin-settings" app | ||
| And "Admin" navigates to the groups management page | ||
| When "Admin" changes displayName to "a renamed group" for group "sales" using the sidebar panel |
Contributor
There was a problem hiding this comment.
we didn't add an assertion step 🤦 . please add it now
Comment on lines
+143
to
+159
| await objects.a11y.Accessibility.assertNoSevereA11yViolations( | ||
| page, | ||
| ['body'], | ||
| 'body after deleting group' | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| await objects.a11y.Accessibility.assertNoSevereA11yViolations( | |
| page, | |
| ['body'], | |
| 'body after deleting group' | |
| ) |
Contributor
Author
There was a problem hiding this comment.
The group list is changed and the toast appears after deletion, so I thought it would be better to check the the whole body for accessibility.
Comment on lines
+110
to
+126
| await objects.a11y.Accessibility.assertNoSevereA11yViolations( | ||
| page, | ||
| ['body'], | ||
| 'body after deleting group' | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| await objects.a11y.Accessibility.assertNoSevereA11yViolations( | |
| page, | |
| ['body'], | |
| 'body after deleting group' | |
| ) |
Contributor
Author
There was a problem hiding this comment.
The group list is changed and the toast appears after deletion, so I thought it would be better to check the the whole body for accessibility.
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
from
d42ee93 to
1e9fde6
Compare
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
from
1e9fde6 to
4dfa18c
Compare
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
2 times, most recently
from
c497f12 to
d1b1b8e
Compare
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
from
d1b1b8e to
3e2fd08
Compare
anon-pradip
force-pushed
the
test/e2e-playwright-groups.feature
branch
from
3e2fd08 to
28c94de
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates groups.feature end-to-end tests from Cucumber/Gherkin to Playwright test framework.
Separated
getDisplayedGroupsIds(for UUIDs) andgetGroupsDisplayName(for display names) to avoid UI hangs during dynamic updates.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: