Open
Conversation
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview🐛 Fixes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
We use auto-parallelizable, an annotation processor we made that uses the worker api so forces Gradle to run tasks in parallel. At one point, using the worker api was necessary to indicate to Gradle that the task should be run in parallel. However, modern Gradle is way smarter and now you can just write a "normal task" and provided you don't do anything naughty (eg
getProject()call inside a task action, or complex Gradle domain object input likeConfiguration) then it will run the task in parallel (these broadly correspond to the configuration cache rules). We now have errorprone checks in gradle-guide that should prevent most of these mistakes.When rolling out
javaCompiler, there are some failures (circle, PR) becauseauto-parallelizablepackages an old version ofgoethe, which packages an old version ofpalantir-java-format, which does not work with a 25 compiler:After this PR
==COMMIT_MSG==
Stop using auto-parallelizable on tasks, instead use regular tasks.
==COMMIT_MSG==
Rely on our errorprones to ensure tasks are parallelisable, stop using this annotation processor.
Testing
Relying on the existing automated tests.
Possible downsides?
Technical breaking change, but no one seems to use these tasks directly thankfully, so should be fine.
Are Docs needed?
🤖 Generated with Claude Code