Re-write

[SwissalpS]

Full re-write, details in CHANGES.txt

[SwissalpS]

I tried it with the db from pandorabox and it doesn't crash.
But if we aren't using the db for anything anyway, I suggest we turn the statistics off.

[SwissalpS]

This part is a bit ugly:

smartshop/mail.lua

Lines 4 to 16 in 33e034a

	local wants_table = false
	do
	-- TODO: this is an ugly work-around to figure out which
	-- mail mod is used. If somebody sees a cleaner way to
	-- detect versions/forks, please change this.
	local success, error = pcall(mail.send, nil, nil, nil, '')
	if (not success) and error
	and smartshop.string_contains_string(error,
	"attempt to index local 'm' (a nil value)")
	then
	wants_table = true
	end
	end

An alternative I see is to add a server setting smartshop.mail_wants_tables or similar to have cleaner code.

[OgelGames]

The current version of the mail mod has mail.version = 3, and the old version (which fluxionary's fork is based on) has mail.apiversion = 1.1. The only other mod using the mail namespace is SmallJoker's old mod, which doesn't have any identifier.
https://github.com/mt-mods/mail/blob/master/init.lua#L3
https://github.com/fluxionary/minetest-mail/blob/master/init.lua#L3
https://github.com/SmallJoker/mail/blob/master/init.lua

[SwissalpS]

The mt-mods one uses apiversion 1.1 long after it has added support for a table.
Only changes and jumps to version 3 here: mt-mods/mail@b3e0c15#diff-0fc5c43f6f1d7605fd7d16c088ba6b83f096eee8e2049517407bbaa27aa3a4f7
I hope that is good enough.

[SwissalpS]

If there are no objections, I'll merge sometime this week.

[BuckarooBanzay]

If there are no objections, I'll merge sometime this week.

thanks for the work, hadn't time/headspace to take a look at this, sorry