Fix PHPCS violations and re-enable style linting workflow #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
AnaisPantheor
previously approved these changes
Nov 17, 2025
jazzsequence
requested changes
Nov 20, 2025
Contributor
jazzsequence
left a comment
jazzsequence
left a comment
There was a problem hiding this comment.
If we're tackling this, we should use Pantheon WP Coding Standards rather than default WPCS for consistency with our other plugins. Otherwise, we'll likely need to make more PHPCS adjustments in the future if/when we migrate to use our own standards.
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Reverts the multi-line concatenated base64 string workaround and uses the proper phpcs ignore comment approach, consistent with Settings.php.
AnaisPantheor
force-pushed
the
fix/phpcs-issues
branch
from
416104d to
881cb17
Compare
…ine length issues" This reverts commit e9f732f.
This allows i18n strings to exceed line length limits without failing CI, since WordPress i18n requires single literal strings for translation extraction.
WordPress i18n requires single literal strings for translation extraction.
Show line length warnings clearly in CI output while still passing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes PHPCS code style violations and enables the PHP style linting workflow to run on all future PRs
PSR1.Files.SideEffectsrule (WordPress ABSPATH security checks conflict with PSR-1)Test plan