Gap Sync: Skip Body Requests for Non-Archive Nodes#10752
Gap Sync: Skip Body Requests for Non-Archive Nodes#10752lrubasze wants to merge 31 commits intolrubasze/block-import-improvementsfrom
Conversation
This reverts commit 2bca30a0c5d6cc2f3405a04d6f3c1177d95614a0.
|
/cmd prdoc --audience node_dev --audience node_operator --bump patch --force |
…e_dev --audience node_operator --bump patch --force'
skunert
left a comment
There was a problem hiding this comment.
Overall logic looks quite good. Ome thing you can do is make this behaviour a bit more explicit by adding a node to the warp sync CLI. Just a quick mention so that users can know what state the node will be in when warp sync is finished.
|
cc: @karolk91 maybe it looks like something related what we discussed the last week? |
|
/cmd prdoc --audience node_dev --audience node_operator --bump patch --force |
…e_dev --audience node_operator --bump patch --force'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
looks related indeed, @lrubasze can we hold a bit with merge of this ? I will be soon exploring how warp syncing related to bulletin parachain works.. but my current understanding is that this is a case when we have block pruning set but still need also possible that I'm mixing here the concept of relay chain warp syncing and parachain warp syncing |
|
/cmd fmt |
Summary
This PR optimizes gap sync bandwidth usage by skipping body requests for non-archive nodes. Bodies are unnecessary during gap sync when the node doesn't maintain full block history, while archive nodes continue to request bodies to preserve complete history.
It reduces bandwidth consumption and database size significantly for typical validator/full nodes.
Additionally added some gap sync statistics for observability:
GapSyncStatsto track bandwidth usage: header bytes, body bytes, justification bytes