Remove unused code in staking-async

[kianenigma]

• remove the reward-fn from pallet-staking-async. This crate is no longer needed.
• rename ahm-test to integration-tests

[sigurpol]

probably worth backporting to 2512 as well to simplify following staking PRs backporting (e.g. DAP satellite, session keys etc) for 2512 since this will be probably merged first. @kianenigma wdyt?

[kianenigma]

Sure can do!

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501414
Failed job name: test-linux-stable-runtime-benchmarks

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501427
Failed job name: check-runtime-migration

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501414
Failed job name: test-linux-stable

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501427
Failed job name: check-runtime-migration

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/21248501597
Failed job name: build-templates-node

[kianenigma]

/cmd prdoc generate --bump major

[kianenigma]

/cmd prdoc --bump major

[sigurpol]

We had some annoyance recently while backporting PRs with major changes that ended up not being strictly major in reality... I guess we might end up backporting this PR as well if we merge it before the pending DAP stuff for phase 1 since it probably makes merging easier and it's no risk. My question here is : do we feel that the removal of reward-fn without public API or anything is really a major change?

[kianenigma]

I am actually holding this off until the rest of your work is done, as this is not at all important, I just did it for a bit of cleanup :) so better if we merge it only after your PRs are merged, and without backport?

My question here is : do we feel that the removal of reward-fn without public API or anything is really a major change?

I am generally of the opinion that pallet-staking-async is not part of the general FRAME, and as someone recently suggested more in the class of ./polkadot/runtime, so I don't bother too much with thinking about if/how it breaks something. Not sure if I fully understood the question though.

[sigurpol]

thanks for not merging immediately 😉 so yes, merging after DAP satellite would be perfect. And then up to you if you want to backport or not.

I agree on the recent discussion's outcome to have staking pallets outside frame - but yeah, until then any major change need to be handled ad-hoc while backporting. So here my suggestion was to use minor or patch since we are not really breaking any contract with external users