EP Register prototype #71
Conversation
First approach of implementing the EP Register endpoints
debug 1
Bumps [jupyter-core](https://github.com/jupyter/jupyter_core) from 4.11.1 to 4.11.2. - [Release notes](https://github.com/jupyter/jupyter_core/releases) - [Changelog](https://github.com/jupyter/jupyter_core/blob/main/CHANGELOG.md) - [Commits](jupyter/jupyter_core@4.11.1...4.11.2) --- updated-dependencies: - dependency-name: jupyter-core dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…/jupyter-core-4.11.2 Bump jupyter-core from 4.11.1 to 4.11.2
Add graceful error for misconfigured EPO login information
First approach of implementing the EP Register endpoints
debug 1
parkerhancock
left a comment
parkerhancock
left a comment
There was a problem hiding this comment.
Hey! Can we delete this and replace with standalone test files?
We need a api_test.py file with your API test method, and a manager_test.py file with what you've called a model test (but I would call a manager test).
Take a look at the manager_test.py and api_test.py as examples. All you need is a class or set of functions that runs some bit of code, and then assert statements to check for correct output.
parkerhancock
left a comment
parkerhancock
left a comment
There was a problem hiding this comment.
Let's clean this file up, and get rid of the API's we don't use. Register only has a Search / Retrieval / Events / Procedural Steps endpoints, so we can delete the rest.
Remember, this is all in version control, so don't worry about losing information by deleting it, it will always be in the version history!
| @@ -0,0 +1,29 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
Hey! Can we delete this and replace with standalone test files?
We need a api_test.py file with your API test method, and a manager_test.py file with what you've called a model test (but I would call a manager test).
Take a look at the manager_test.py and api_test.py as examples. All you need is a class or set of functions that runs some bit of code, and then assert statements to check for correct output.
| @@ -0,0 +1,175 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Let's clean this file up, and get rid of the API's we don't use. Register only has a Search / Retrieval / Events / Procedural Steps endpoints, so we can delete the rest.
Remember, this is all in version control, so don't worry about losing information by deleting it, it will always be in the version history!
|
Ignore the comments above, and take a look at the code - I thought I was adding those comments to specific files and didn't. Sorry! |
|
FYI - I am still working on this, but given the insane complexity of the documents fed back by the Register endpoint, I'm investigating a code generation approach to the Schema / Model files that build them from the XML schema file provided by the EPO. Thanks! Parker |
2 participants
First approach of implementing the EP Register endpoints