[3.x] Add "--xdebug" CLI option to enabled Xdebug #1158
+67
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravage84
added
Feature
Dependencies
Needs Tests
RFC
PHAR
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1158 +/- ##
============================================
- Coverage 90.91% 90.45% -0.47%
- Complexity 1325 1331 +6
============================================
Files 109 110 +1
Lines 3447 3466 +19
============================================
+ Hits 3134 3135 +1
- Misses 313 331 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AJenbo
reviewed
May 15, 2024
AJenbo
reviewed
May 15, 2024
Member
Did you propose the change upstream? |
Member
Author
Not yet |
Co-authored-by: Anders Jenbo <anders@jenbo.dk>
ravage84
commented
May 15, 2024
AJenbo
previously approved these changes
May 16, 2024
Member
AJenbo
left a comment
AJenbo
left a comment
There was a problem hiding this comment.
just don't forget to remove it if they accept it upstream :D
kylekatarnls
previously approved these changes
Jun 10, 2024
kylekatarnls
approved these changes
Jun 10, 2024
kylekatarnls
requested changes
Jun 10, 2024
Member
kylekatarnls
left a comment
kylekatarnls
left a comment
There was a problem hiding this comment.
All good, we just need a unit test to cover src/main/php/PHPMD/TextUI/XdebugOptionHandler.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Feature
Issue: Resolves None
Breaking change: No
Inspired by https://dev.to/serendipityhq/how-to-debug-any-symfony-command-simply-passing-x-214o
This could easily be a feature of composer/xdebug-handler itself, if they would want to.