Skip to content

Conversation

@yubiuser yubiuser changed the title vNext PADD v4.1.0 Mar 28, 2025
@yubiuser yubiuser requested a review from Copilot March 28, 2025 16:01

This comment was marked as outdated.

DL6ER and others added 8 commits March 28, 2025 17:07
updates from review

more updates from review

fix dhcp string to checkbox

fix dhcp ip range display

fix dhcp ip range display again

enhance dhcp range display

Update padd.sh

Co-authored-by: RD WebDesign <[email protected]>
Signed-off-by: Christian Boyle <[email protected]>

add newline at end of file, per editorconfig-checker failure

Update padd.sh

Co-authored-by: yubiuser <[email protected]>
Signed-off-by: Christian Boyle <[email protected]>
Co-authored-by: k-rister <[email protected]>
Signed-off-by: yubiuser <[email protected]>
@yubiuser yubiuser requested a review from Copilot August 5, 2025 07:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR releases PADD v4.1.0 with significant improvements to API handling, privacy features, and overall functionality. The release includes new functionality for API location specification, privacy level handling, and run-once mode, along with numerous bug fixes and code improvements.

  • Added support for specifying API location directly and run-once mode functionality
  • Improved API response parsing, authentication handling, and privacy level support
  • Fixed multiple spelling errors and enhanced dependency checking

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
padd.sh Main implementation with API improvements, privacy handling, run-once mode, and various bug fixes
README.md Updated documentation with dependency list and usage clarifications
.github/dependabot.yml Removed reviewers configuration
.github/CODEOWNERS Added new code owners configuration
.gitattributes Simplified to enforce Unix line endings only

dependabot bot and others added 19 commits August 16, 2025 10:38
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.2.2...v5.0.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 9.1.0 to 10.1.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9.1.0...v10.1.0)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: 10.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker) from f40bac9e7d9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4.
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases)
- [Commits](editorconfig-checker/action-editorconfig-checker@f40bac9...1a41284)

---
updated-dependencies:
- dependency-name: editorconfig-checker/action-editorconfig-checker
  dependency-version: 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 (#478)
Bumps [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker) from 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787.
- [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases)
- [Commits](editorconfig-checker/action-editorconfig-checker@1a41284...5ecdd65)

---
updated-dependencies:
- dependency-name: editorconfig-checker/action-editorconfig-checker
  dependency-version: 5ecdd656fe347c26f76b1b435b90e1d74fb5e787
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787 (#479)
@yubiuser yubiuser requested a review from a team October 26, 2025 20:32
@yubiuser
Copy link
Member Author

Ready for review + merge +release

@rdwebdesign
Copy link
Member

I tested and it seems to be working.

I only found a small "issue", but I'm not sure if some will encounter this issue in real life:

I tested the screen sizes by starting PADD in a big window and then I slowly shrink the window. All sizes worked correctly, when the screen became to small, the "ants" text wasn't displayed and everything was messed.

If I try to start PADD using the same small screen the "Error! PADD isn't for ants!" is correctly displayed.

I don't think this issue is recent and I'm not sure if this is really a big issue. No one should try to use a window that small.

@yubiuser
Copy link
Member Author

This is kind of expected. We prevent startup in ant-size, but don't check later. I think I removed the check because I was annoyed while checking the resize function that I killed PADD when I shrinkend the screen too much.
We could add an exception and display the ant info without exiting PADD. But then: why not allow startup if the screen is too small - maybe they can resize it and enjoy PADD.

@rdwebdesign
Copy link
Member

I think I removed the check because I was annoyed while checking the resize function that I killed PADD when I shrinkend the screen too much.

I know the feeling... that's why my size test was started with the biggest screen and I was shrinking it. I was expecting PADD to exit with "ants" message.

If this is expected, it is approved.

@yubiuser yubiuser merged commit d8aa4f8 into master Oct 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants