-
-
Notifications
You must be signed in to change notification settings - Fork 130
PADD v4.1.0 #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PADD v4.1.0 #438
Conversation
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: Rob Gill <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: yubiuser <[email protected]>
…or that Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
updates from review more updates from review fix dhcp string to checkbox fix dhcp ip range display fix dhcp ip range display again enhance dhcp range display Update padd.sh Co-authored-by: RD WebDesign <[email protected]> Signed-off-by: Christian Boyle <[email protected]> add newline at end of file, per editorconfig-checker failure Update padd.sh Co-authored-by: yubiuser <[email protected]> Signed-off-by: Christian Boyle <[email protected]>
Signed-off-by: darkexplosiveqwx <[email protected]>
Co-authored-by: k-rister <[email protected]> Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR releases PADD v4.1.0 with significant improvements to API handling, privacy features, and overall functionality. The release includes new functionality for API location specification, privacy level handling, and run-once mode, along with numerous bug fixes and code improvements.
- Added support for specifying API location directly and run-once mode functionality
- Improved API response parsing, authentication handling, and privacy level support
- Fixed multiple spelling errors and enhanced dependency checking
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| padd.sh | Main implementation with API improvements, privacy handling, run-once mode, and various bug fixes |
| README.md | Updated documentation with dependency list and usage clarifications |
| .github/dependabot.yml | Removed reviewers configuration |
| .github/CODEOWNERS | Added new code owners configuration |
| .gitattributes | Simplified to enforce Unix line endings only |
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.2.2...v5.0.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 9.1.0 to 10.1.0. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9.1.0...v10.1.0) --- updated-dependencies: - dependency-name: actions/stale dependency-version: 10.1.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker) from f40bac9e7d9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4. - [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases) - [Commits](editorconfig-checker/action-editorconfig-checker@f40bac9...1a41284) --- updated-dependencies: - dependency-name: editorconfig-checker/action-editorconfig-checker dependency-version: 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…9e7d298fbe36b83e1eff8f0de13fb8 to 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 (#478)
Bumps [editorconfig-checker/action-editorconfig-checker](https://github.com/editorconfig-checker/action-editorconfig-checker) from 1a41284d59c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787. - [Release notes](https://github.com/editorconfig-checker/action-editorconfig-checker/releases) - [Commits](editorconfig-checker/action-editorconfig-checker@1a41284...5ecdd65) --- updated-dependencies: - dependency-name: editorconfig-checker/action-editorconfig-checker dependency-version: 5ecdd656fe347c26f76b1b435b90e1d74fb5e787 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…c6fe7f1b21ddc4a2b36400a33dc1b4 to 5ecdd656fe347c26f76b1b435b90e1d74fb5e787 (#479)
Signed-off-by: yubiuser <[email protected]>
|
Ready for review + merge +release |
|
I tested and it seems to be working. I only found a small "issue", but I'm not sure if some will encounter this issue in real life: I tested the screen sizes by starting PADD in a big window and then I slowly shrink the window. All sizes worked correctly, when the screen became to small, the "ants" text wasn't displayed and everything was messed. If I try to start PADD using the same small screen the "Error! PADD isn't for ants!" is correctly displayed. I don't think this issue is recent and I'm not sure if this is really a big issue. No one should try to use a window that small. |
|
This is kind of expected. We prevent startup in ant-size, but don't check later. I think I removed the check because I was annoyed while checking the resize function that I killed PADD when I shrinkend the screen too much. |
I know the feeling... that's why my size test was started with the biggest screen and I was shrinking it. I was expecting PADD to exit with "ants" message. If this is expected, it is approved. |
PADD release
New
Removed
Fixes
API_URL#450Other