Fix the /start and /offer/api proxy endpoints for smallWebRTC to matc… #3537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h pipecat cloud behavior WRT requestData
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR modifies the SmallWebRTC endpoints to align with Pipecat Cloud behavior regarding requestData handling. The changes ensure that custom parameters must be embedded in a body field when sent to the /start endpoint, making the SmallWebRTC implementation consistent with the Daily transport.
Changes:
- Modified
/startendpoint to store only thebodyfield fromrequestDatain the session storage - Added fallback logic in the
/sessions/{session_id}/api/offerproxy endpoint to use stored session data whenrequest_dataorrequestDataare not provided
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…h pipecat cloud behavior WRT requestData
Please describe the changes in your PR. If it is addressing an issue, please reference that as well.
requestDatawhen sending any custom parameters they want passed through to the runner args for SmallWebRTC. Any custom args must now be embedded in abody: {}field ofrequestDatain the/startendpoint. This aligns expectations with the Daily /start endpoint as well as pipecat cloud.