Further fixes for TS migration of PCUI extension classes #1705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to pcui-errors
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the TypeScript migration of PCUI extension classes by adding comprehensive type annotations, improving documentation, and fixing several bugs.
Changes:
- Converted JavaScript classes to TypeScript with proper type definitions and interfaces
- Fixed two bugs: incorrect property reference (
_sort.sortKey→_sort.key) and event listener typo (mouesup→mouseup) - Corrected spelling from British to American English for consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| template-thumbnail-renderer.ts | Fixed spelling in comment (Neutralise → Neutralize) |
| element-table.ts | Added TypeScript types, interfaces, and fixed _sort.key reference bug |
| element-table-row.ts | Added type annotations and improved constructor argument handling |
| element-table-cell.ts | Added type annotations and implemented colSpan getter/setter |
| element-layers-input.ts | Added TypeScript types and improved type safety |
| element-gradient-input.ts | Added comprehensive type annotations and private field declarations |
| element-entity-input.ts | Added type annotations and corrected flexGrow to string type |
| element-drop-target.ts | Added type annotations and improved null safety with optional chaining |
| element-drop-manager.ts | Added type annotations and fixed mouseup event listener typo |
| element-curve-input.ts | Added comprehensive type annotations |
| element-color-input.ts | Added type annotations and removed unused _isColorPickerOpen field |
| element-bundles-input.ts | Added type annotations and improved method signatures |
| element-batchgroup-input.ts | Added type annotations and optional chaining for safety |
| element-asset-thumbnail.ts | Fixed spelling in comment (optimisations → optimizations) |
| element-asset-list.ts | Added type annotations and fixed typo in comment (seach → search) |
| element-asset-input.ts | Added type annotations and cleaned up constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.