Skip to content

Added directives hint for validation of the default_language field …#73

Merged
mauritsvanrees merged 3 commits intomasterfrom
addHintForValidation
Mar 24, 2025
Merged

Added directives hint for validation of the default_language field …#73
mauritsvanrees merged 3 commits intomasterfrom
addHintForValidation

Conversation

@sneridagh
Copy link
Member

…in languages control panel.

@mister-roboto
Copy link

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@sneridagh
Copy link
Member Author

@jenkins-plone-org please run jobs

@sneridagh
Copy link
Member Author

@jenkins-plone-org please run jobs

@sneridagh
Copy link
Member Author

@mauritsvanrees @davisagli it would be great to have this in 6.1.1.

@mauritsvanrees
Copy link
Member

I tried this in a client project, but it does not help for me.
Does this need a specific version of Volto or of plone.restapi?

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, when I try Volto main branch and Plone coredev 6.2, this works.

@mauritsvanrees mauritsvanrees merged commit 61b71e8 into master Mar 24, 2025
16 checks passed
@mauritsvanrees mauritsvanrees deleted the addHintForValidation branch March 24, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants