refactor: move vscode settings setup to pnpm postinstall hook#7834
Open
refactor: move vscode settings setup to pnpm postinstall hook#7834
Conversation
- Remove vscodesettings.js execution from make install targets - Add .vscode/settings.json to .gitignore - Remove .vscode/settings.json from git tracking - Add postinstall hook to package.json to run vscodesettings.js - Fix script to properly check if settings.json exists before reading
wesleybl
requested review from
davisagli,
pnicolli,
sneridagh and
stevepiercy
Member
Author
|
See: #7758 (comment) |
Member
|
@wesleybl I still haven't taken action on this one, because I'm still not sure about commiting the My take: leave it as it was. If we decide otherwise, then the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Therefore, when we run
make install,settings.jsonwill not appear as modified in git, and the settings will be added to the file. They will also be added when onlypnpm installis run.