Update Font Awesome icons to version 7 #580
Open
+18
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaviermawet
changed the title
Collaborator
|
Nice, thanks. Have you checked the icon names? (If I recall correctly quite a few changed between fa5 -> fa6.) |
Contributor
Author
|
Yes, no name changes have been made to the icons used in your template, at least not at the time I created my pull request. I'll rebase my branch on top of your master branch to incorporate the latest changes and ensure it still builds correctly. Regards, |
Contributor
|
I confirm that the icon names haven't changed in fontawesome7 |
# Conflicts: # awesome-cv.cls
Add Dockerfile matching GitHub workflow
xaviermawet
force-pushed
the
feature/fontawesome7
branch
from
8148860 to
c5c3d72
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request updates Font Awesome icons to version 7.
It uses the new fontawesome7 CTAN package, developed by the same author as the previous fontawesome6 package.