Rename default instances. #25643
Merged
Rename default instances. #25643
+684
−719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_862956528
branch
3 times, most recently
from
91093b2 to
172eafc
Compare
This CL prepares upcoming changes to collocate message-globals under a single wrapper (go/proto-msg-globals). The plan is to keep dual state guarded by PROTOBUF_MESSAGE_GLOBALS, which allows smaller CLs and potential A/B experiments. Exising code exposes a raw default instance to messages that contain the type to support constinit or constexpr. Using `T::default_instance()` would encapsulate #ifdef'ing but I didn't find a way to achieve that. (Also, constexpr doesn't allow reinterpret_cast.) This CL renames existing raw default instances so that both branches (#ifdef & #ifndef) can refer to the same name. ``` // Before: struct FooDefaultTypeInternal; extern FooDefaultTypeInternal _Foo_default_instance_; DoSomething(_Foo_default_instance_._instance); // After struct FooGlobalsTypeInternal; extern FooGlobalsTypeInternal _Foo_globals_; DoSomething(_Foo_globals_._default); ``` Note that this is meant to be name changes only. PiperOrigin-RevId: 864580684
copybara-service
bot
force-pushed
the
test_862956528
branch
from
172eafc to
33e255c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename default instances.
This CL prepares upcoming changes to collocate message-globals under a single
wrapper (go/proto-msg-globals). The plan is to keep dual state guarded by
PROTOBUF_MESSAGE_GLOBALS, which allows smaller CLs and potential A/B experiments.
Exising code exposes a raw default instance to messages that contain the type
to support constinit or constexpr. Using
T::default_instance()would encapsulate#ifdef'ing but I didn't find a way to achieve that. (Also, constexpr doesn't allow
reinterpret_cast.)
This CL renames existing raw default instances so that both branches (#ifdef & #ifndef)
can refer to the same name.
Note that this is meant to be name changes only.