Skip to content

Conversation

@romanofski
Copy link
Member

@romanofski romanofski commented Jan 8, 2025

This uses the improvements from purebred-mua/purebred-email#88 as the current code is unable to parse addresses in the mutt alias file using non-ASCII characters.

This uses the text address parser since the ByteString parser would expect the addresses in the mutt alias file to be content encoded. Don't think we want to expect users to do this.

Fixes #515

@romanofski romanofski force-pushed the fix/muttaliasparsing branch 5 times, most recently from c90d987 to 48c17a3 Compare December 7, 2025 04:29
@frasertweedale
Copy link
Member

faily test:

     exit vim                   (0.03s)
      user error (Text.Regex.Posix.ByteString died: (ReturnCode 8,"Unmatched ( or \\("))

@romanofski
Copy link
Member Author

Yeah... I'll need to reserve some time to have a look.

@romanofski
Copy link
Member Author

Issue is in tasty-tmux as it can't match unicode characters. See purebred-mua/tasty-tmux#20

@romanofski romanofski force-pushed the fix/muttaliasparsing branch 10 times, most recently from e42d240 to 55f53a8 Compare December 25, 2025 02:05
@romanofski
Copy link
Member Author

Yay Christmas present... Seems we don't need to jump to a different regex engine alltogether. For whatever reason I don't fully grok yet is that the ByteString with extended UTF8 characters was causing failures. Using Text.encodeUtf8 seems to properly encode the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading (mutt) aliases from a file can not handle non-ascii characters

3 participants