Skip to content

Conversation

@PerchunPak
Copy link
Member

To limit Python version, so we can use latest Sphinx (they drop old Python versions very quickly, before they become EOL)

@PerchunPak PerchunPak requested a review from ItsDrike January 23, 2026 22:20
@PerchunPak
Copy link
Member Author

Unfortunately, it fails silently when you do uv sync --group docs with 3.11. poe docs just shows sphinx-build command not found. Don't know how to display a user friendlier error

@ItsDrike
Copy link
Member

ItsDrike commented Jan 23, 2026

Hmm, I don't (well, other than doing something like command -v sphinx-build >/dev/null 2>&1 && sphinx-build ... || echo "Missing docs dependency group", but it feels a bit hacky, also, it wouldn't work for windows devs)

Copy link
Member

@ItsDrike ItsDrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will renovate pick up the second pyproject.toml and take care of updating it properly as a subproject?

@ItsDrike ItsDrike added the a: dependencies Related to package dependencies and management label Jan 23, 2026
@PerchunPak
Copy link
Member Author

Will renovate pick up the second pyproject.toml and take care of updating it properly as a subproject?

It should, but I have no way of testing it

@PerchunPak
Copy link
Member Author

Hmm, I don't (well, other than doing something like command -v sphinx-build >/dev/null 2>&1 && sphinx-build ... || echo "Missing docs dependency group", but it feels a bit hacky, also, it wouldn't work for windows devs)

I don't think we even support building docs on Windows, there should be a Makefile.bat I think

To limit Python version, so we can use latest Sphinx (they drop old
Python versions very quickly, before they become EOL)
@PerchunPak PerchunPak merged commit 3f1ad78 into master Jan 24, 2026
10 checks passed
@PerchunPak PerchunPak deleted the docs-as-workspace branch January 24, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: dependencies Related to package dependencies and management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants