gh-144067: Fix memory leak when initscr() follows setupterm() #144076
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling setupterm() before initscr() can leak memory: setupterm()
allocates the global ncurses cur_term, and initscr() internally
reinitializes the terminal (via newterm()) without freeing the
existing cur_term.
This change frees an existing cur_term before calling initscr(),
preventing the leak observed under ASAN.
Note: the _curses module is not available on Windows, so this change
was not runtime-tested locally. The fix is minimal and follows the
ncurses API’s ownership rules; Linux/macOS CI should cover the affected
code path.