[xpu][fix] fix errors related to maxnreg on xpu #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
oulgen
requested changes
Jan 23, 2026
Contributor
oulgen
left a comment
oulgen
left a comment
There was a problem hiding this comment.
Please refactor to a common helper function under compat.py
helion/autotuner/config_spec.py
Outdated
|
|
||
| # Only validate maxnreg on non-AMD devices (not supported on AMD) | ||
| if torch.version.hip is None: | ||
| if torch.version.hip is None and torch.version.xpu is None: |
Contributor
There was a problem hiding this comment.
can you create supports_maxnreg() function under compat.py?
also update the comment here and all the following places
oulgen
approved these changes
Jan 23, 2026
helion/_compiler/device_function.py
Outdated
| "maxnreg" in self.config | ||
| and self.config["maxnreg"] is not None | ||
| and torch.version.hip is None | ||
| and (torch.version.hip is None and torch.version.xpu is None) |
jianyizh
commented
Jan 23, 2026
| @patch.object(_compat, "_supports_tensor_descriptor", lambda: True) | ||
| @patch.object(loops, "_supports_warp_specialize", lambda: True) | ||
| @patch("torch.version.hip", None) | ||
| @patch("torch.version.xpu", None) |
Contributor
Author
There was a problem hiding this comment.
AMD ci failed here. I don't have AMD machine to debug. I suppose this can pass ci
Contributor
There was a problem hiding this comment.
The problem is functools.cache is ignoring the patch here, you need to do similar to _supports_tensor_descriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxnreg is not supported on xpu