Add alternative connection limits option for seeding torrents

[lstrsrt]

This PR adds a new option to the Connection settings: a checkbox + spinbox "Maximum number of connections per seeding torrent" which allows the user to configure a different connection limit for seeding torrents. The rationale for this is laid out in #2193 -- basically it is not necessary to have as many connections when seeding a torrent vs when downloading it. I have not worked on this codebase before, let me know if there is a better way to achieve this.

Addresses #2193.

Edit: Updated screenshot.

[glassez]

What immediately caught my eye in the screenshot is the confusing option "Alternative limit for seeding torrent". It looks like it should be a sub-option of "Maximum number of connections per torrent". Otherwise, it should contain the same text, e.g. "Maximum number of connections per seeding torrent".

[lstrsrt]

The option naming was inspired from the screenshot in the linked issue. It is meant to imply that it is a suboption of the option above it (the screenshot doesn't show it, but the checkbox can only be toggled when "Maximum number of connections per torrent" is enabled).

I'm thinking it may be better to just make it a separate option though, so that users can set a limit only for seeding torrents.

Edit: Also starting to think that the "AltConnections" naming in the code is unclear. "SeedConnections" would be clearer. Will update this later.

[glassez]

It is meant to imply that it is a suboption of the option above it (the screenshot doesn't show it, but the checkbox can only be toggled when "Maximum number of connections per torrent" is enabled).

Usually suboptions in qBittorrent look like the following:

[glassez]

I'm thinking it may be better to just make it a separate option though, so that users can set a limit only for seeding torrents.

I agree.

the "AltConnections" naming in the code is unclear.

👍

[glassez]

"SeedConnections" would be clearer.

👎
It's a torrent who is seed.
So it should be "MaxConnectionsPerSeedingTorrent".
"MaxConnectionsPerTorrent" should become "MaxConnectionsPerDownloadingTorrent" to be consistent.

[lstrsrt]

Ok, renaming done. Hopefully didn't miss anything (I tried to automate it with sed as best as I could).

Also I guess this requires a DB upgrade due to changing an existing option name... see newest commit.

Edit: Or alternatively this commit could be dropped and the DB name kept as-is. But then it would be inconsistent with the names in the code.

[github-actions]

This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity.

[lstrsrt]

Bump. As far as I can tell, the failed checks are unrelated to the code added here.

[xavier2k6]

@qbittorrent/bug-handlers Does no one have anything to say about it?

I've no issue with it except for the "add to torrent option" part of #2193 (comment) wasn't addressed.

If it's done in another PR, then that'll be ok too.

No real blockers otherwise.

[stalkerok]

There is another related request for a feature that would also be in demand

• Limit maximum number of connections per specific torrent #6031

This would be useful for me for different storage devices. Most often, these limits are only needed for individual torrents.

I would even say that this PR does not solve #2193
It also says: connections per torrent (see the last screenshot)

[lstrsrt]

I would even say that this PR does not solve #2193 It also says: connections per torrent (see the last screenshot)

I was meaning to add this in another PR once this one has been merged. But I'll change the PR description to "address" instead of "resolve".

[Chocobo1]

Last comment from me.

[stalkerok]

@lstrsrt, resolve merge conflicts.

[lstrsrt]

@stalkerok
Done

[thalieht]

Probably not important but i'll say it:
When starting a seeding torrent with the settings like this:

• Maximum number of connections per downloading torrent
• Maximum number of connections per seeding torrent

On first refresh in the peer list, the amount of peers appearing is equal to whatever is set in Maximum number of connections per downloading torrent. Then more peers show up in the next refresh. This doesn't happen on a downloading torrent when these settings are reversed.