Skip to content

WebAPI: Resolve peer host names#23708

Merged
glassez merged 4 commits intoqbittorrent:masterfrom
Piccirello:webui-peer-host-name
Jan 18, 2026
Merged

WebAPI: Resolve peer host names#23708
glassez merged 4 commits intoqbittorrent:masterfrom
Piccirello:webui-peer-host-name

Conversation

@Piccirello
Copy link
Member

This PR adds WebAPI support for resolving peer host names, and WebUI support for displaying resolved host names. This mirrors the existing GUI functionality.

Closes #13096.

@Piccirello Piccirello added this to the 5.2 milestone Jan 6, 2026
@Piccirello Piccirello requested a review from a team January 6, 2026 03:13
@Piccirello Piccirello added WebUI WebUI-related issues/changes WebAPI WebAPI-related issues/changes labels Jan 6, 2026
@Piccirello Piccirello force-pushed the webui-peer-host-name branch from 349647b to 699183f Compare January 6, 2026 03:15
@Piccirello Piccirello force-pushed the webui-peer-host-name branch from 699183f to 5f3d71a Compare January 6, 2026 23:05
@Piccirello
Copy link
Member Author

All feedback addressed

@Piccirello Piccirello requested a review from glassez January 6, 2026 23:09
@Piccirello Piccirello force-pushed the webui-peer-host-name branch from 5f3d71a to 3147aae Compare January 8, 2026 23:52
@Piccirello Piccirello requested a review from glassez January 9, 2026 03:24
glassez
glassez previously approved these changes Jan 9, 2026
@glassez
Copy link
Member

glassez commented Jan 9, 2026

It would make sense to have single instance of ReverseResolution. However, I do not insist that it is redesigned in this PR.

stalkerok
stalkerok previously approved these changes Jan 9, 2026
@Piccirello
Copy link
Member Author

It would make sense to have single instance of ReverseResolution. However, I do not insist that it is redesigned in this PR.

Completely agree. Will definitely look into this as a future enhancement.

xavier2k6
xavier2k6 previously approved these changes Jan 9, 2026
@Piccirello Piccirello dismissed stale reviews from xavier2k6, stalkerok, and glassez via 86fb7a1 January 11, 2026 18:49
@Piccirello Piccirello force-pushed the webui-peer-host-name branch 2 times, most recently from 86fb7a1 to 945bb21 Compare January 11, 2026 18:50
glassez
glassez previously approved these changes Jan 12, 2026
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be mistaken, but it seems to me that I have discovered some logical bug. I'll comment it in the code.

@Piccirello Piccirello force-pushed the webui-peer-host-name branch from 945bb21 to 3b0b9e0 Compare January 13, 2026 04:20
@Piccirello Piccirello force-pushed the webui-peer-host-name branch from 3b0b9e0 to fd8c3e9 Compare January 13, 2026 04:22
@glassez glassez merged commit 3a46cf8 into qbittorrent:master Jan 18, 2026
15 checks passed
@glassez
Copy link
Member

glassez commented Jan 18, 2026

@Piccirello
Thank you.

Ritmix3300 pushed a commit to Ritmix3300/qBittorrent that referenced this pull request Jan 19, 2026
Chocobo1 pushed a commit that referenced this pull request Feb 6, 2026
In order for the sync algorithm to work properly, we must clear the peer country and country code when peer country resolution is disabled.
Reference: #23708 (comment)

PR #23758.
glassez pushed a commit to glassez/qBittorrent that referenced this pull request Feb 7, 2026
In order for the sync algorithm to work properly, we must clear the peer country and country code when peer country resolution is disabled.
Reference: qbittorrent#23708 (comment)

PR qbittorrent#23758.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reverse DNS Resolution in the WebUI

6 participants