WebUI: Improve table performance#23752
Merged
Chocobo1 merged 3 commits intoqbittorrent:masterfrom Feb 1, 2026
Merged
Conversation
This provides constant time lookups.
Piccirello
force-pushed
the
tom/table-performance
branch
from
000297c to
0d23d10
Compare
Piccirello
changed the title
Chocobo1
reviewed
Jan 24, 2026
glassez
changed the title
This introduces a new `setRows` method for efficiently updating the rows of an existing table. The caller provides `setRows` will the full set of rows to display, and `setRows` efficiently updates existing rows and deletes unused rows. `clear()` is now effectively only called when the full data set changes (i.e. a different torrent is selected).
Piccirello
force-pushed
the
tom/table-performance
branch
from
0d23d10 to
4055016
Compare
Chocobo1
approved these changes
Jan 30, 2026
Member
|
@Piccirello |
Member
|
@Piccirello |
Chocobo1
added a commit
to Chocobo1/qBittorrent
that referenced
this pull request
Feb 6, 2026
This change is incomplete and causes RSS to spam errors in browser console. Fix up: qbittorrent#23752.
Member
Author
Will look into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from an array to a set for O(n) operations.