Revert "Temporarily lower Qt version deprecation"#23794
Revert "Temporarily lower Qt version deprecation"#23794xavier2k6 wants to merge 1 commit intoqbittorrent:masterfrom
Conversation
This reverts 5df4df1 introduced in PR qbittorrent#23499 as upstream fix for [QTBUG-141994](https://bugreports.qt.io/browse/QTBUG-141994) has been publicly released.
Our INSTALL file requires Line 14 in b4b4dd7 |
|
Other questions to ask:
(I haven't built qBittorrent manually since Qt6 introduction, rely on official releases/CI builds for testing) |
|
I think @sledgehammer999 could just work around similar issues locally rather than pushing it in the codebase, given that they don't affect in most of the cases. |
It seems that the only truly safe path is defer this revert until we raise the minimum supported Qt version to 6.8. To be precise, it is Qt 6.8.6 and not 6.8.0, but I hope users will be using the latest release in the 6.8 series. This concern is related to the Qt version specified in the INSTALL file.
It is like all other reported issues. We won't know until someone reports it and then we fix afterwards.
IMO this issue is quite minor and static builds are too slow and require high maintenance, and therefore not worth it.
I can see why he wants it in the codebase. It is about having no local (hidden) changes for a binary release. However, this point is moot since the release build process isn't public. BTW, I strongly support making the release build process public. Similar to what docker and flatpak are doing. |
We've been talking about this for years, but to no avail. @sledgehammer999 doesn't want to let it out of his hands. |
|
How about ammending the If Linux/macOS Qt 6.6.0+ & Windows = Qt 6.8.6/ Qt 6.10.2
|
Yeah, we can setup the whole build process and let sledgehammer999 decide when to push the run button. But I'm not optimistic about it.
I suppose you can still go forward with this PR as-is without my approval if you strongly insist. Also I consider adding OS conditionals to INSTALL a bit too much. It would be OK to add it to cmake though. |
I don't strongly insist but perhaps other @qbittorrent/bug-handlers who haven't contributed to this proposal so far, can weigh-n & express their opinions or suggest alternatives etc.
Another thing with regards to CMake's Requirements is with the
Our Min OpenSSL is Do we put OS conditionals or set an overall minimal (one size fits all)? |
This reverts 5df4df1 introduced in PR #23499 as upstream fix for QTBUG-141994 has been publicly released.
Upstream fixed in
Qt 6.8.6 / Qt 6.10.2 / Qt 6.11.0 Beta3+Qt 6.10.2 Release Announcement
Release Notes
#23499 (comment)