Check whether "getrandom" exists#23805
Open
glassez wants to merge 1 commit intoqbittorrent:masterfrom
Open
Conversation
Under some Linux environments (e.g. Termux) "getrandom" may not actually exist.
xavier2k6
approved these changes
Feb 2, 2026
Chocobo1
reviewed
Feb 3, 2026
| ) | ||
| elseif (CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| include(CheckSymbolExists) | ||
| check_symbol_exists(getrandom "sys/random.h" HAVE_GETRANDOM) |
Member
There was a problem hiding this comment.
What is the actual problem with Termux?
Is this system header not present?
Under some Linux environments (e.g. Termux) "getrandom" may not actually exist.
randomlayer_linux.cpp have fallback path, is it not working?
qBittorrent/src/base/utils/randomlayer_linux.cpp
Lines 48 to 57 in cade7c2
I guess the function simply doesn't exist...
Member
Author
There was a problem hiding this comment.
I guess the function simply doesn't exist...
Yes. The sys/random.h header exists but it defines getrandom function depending on Android API version which is not satisfied by Termux (Termux is built for a lower API version).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some Linux environments (e.g. Termux) "getrandom" may not actually exist.