utils: locate_unixodbc: account for statically built unixodbc (CRAN)#899
Merged
detule merged 2 commits intor-dbi:mainfrom Mar 4, 2025
Merged
utils: locate_unixodbc: account for statically built unixodbc (CRAN)#899detule merged 2 commits intor-dbi:mainfrom
detule merged 2 commits intor-dbi:mainfrom
Conversation
simonpcouch
approved these changes
Mar 3, 2025
Collaborator
simonpcouch
left a comment
simonpcouch
left a comment
There was a problem hiding this comment.
Very grateful you looked into this CRAN issue.
devtools::check_mac_release() fails with CRAN odbc and passes with this PR. Huzzah!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix errors reported on CRAN ( where the build machine is using a statically buit
unixodbc).Used a simple "stop" rather than something with better formatting since that error does not propagate to the user.